Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: [nasa/nos3#254] Build in external directory #415

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

WIP: [nasa/nos3#254] Build in external directory #415

wants to merge 5 commits into from

Conversation

jlucas9
Copy link
Contributor

@jlucas9 jlucas9 commented Nov 20, 2024

Build files are placed in /tmp/nos3.

Closes #254

@jlucas9 jlucas9 self-assigned this Nov 20, 2024
Donnie-Ice
Donnie-Ice approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Donnie-Ice Donnie-Ice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, confirmed it built it /tmp/nos3 and no errors

msuder
msuder approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@msuder msuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and tested. Testing shows that /tmp/nos3 is being used for the build artifacts.

dacarter22
dacarter22 approved these changes Nov 26, 2024
View reviewed changes
Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and runs in /tmp/nos3 successfully

kevincbruce
kevincbruce approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it, appears to work, though EPS appears to have issues returning device data? Not sure if that's tied to this branch though

@jlucas9 jlucas9 changed the title [nasa/nos3#254] Build in external directory WIP: [nasa/nos3#254] Build in external directory Dec 10, 2024
@jlucas9
Copy link
Contributor Author

jlucas9 commented Dec 10, 2024

Note that while this is functional. I'm rethinking using /tmp as the directory. This location is shared between multiple users so on a shared system this falls apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacarter22 dacarter22 dacarter22 approved these changes

@rjbrown2 rjbrown2 rjbrown2 approved these changes

@kevincbruce kevincbruce kevincbruce approved these changes

@Donnie-Ice Donnie-Ice Donnie-Ice approved these changes

@msuder msuder msuder approved these changes

@zlynch2 zlynch2 Awaiting requested review from zlynch2

@Isgaroth-the-Green Isgaroth-the-Green Awaiting requested review from Isgaroth-the-Green

Assignees

@jlucas9 jlucas9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jlucas9 @msuder @Donnie-Ice @kevincbruce @rjbrown2 @dacarter22